refactor: clean up duplicate algorithm implementations to reduce maintenance overhead #7256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the following duplicate implementations: - searches/PerfectBinarySearch.java (duplicate of IterativeBinarySearch) - searches/SortOrderAgnosticBinarySearch.java (duplicate of OrderAgnosticBinarySearch) - strings/LongestPalindromicSubstring.java (duplicate of dynamicprogramming version) - strings/ValidParentheses.java (duplicate of stacks version) - others/cn/HammingDistance.java (duplicate - strings version handles text) - others/NewManShanksPrimeTest.java (orphan test in wrong package) Updated DIRECTORY.md to reflect the changes. Fixes TheAlgorithms#7253
GziXnine
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7256 +/- ##
============================================
- Coverage 79.39% 79.34% -0.05%
+ Complexity 7017 6980 -37
============================================
Files 785 780 -5
Lines 22982 22917 -65
Branches 4520 4501 -19
============================================
- Hits 18246 18184 -62
+ Misses 4016 4014 -2
+ Partials 720 719 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removed 11 duplicate files, For existing contributors working on removed files:
PerfectBinarySearch→ UseIterativeBinarySearchSortOrderAgnosticBinarySearch→ UseOrderAgnosticBinarySearchstrings/LongestPalindromicSubstring→ Usedynamicprogramming/LongestPalindromicSubstringstrings/ValidParentheses→ Usestacks/ValidParenthesesothers/cn/HammingDistance→ Usestrings/HammingDistanceorbitmanipulation/HammingDistanceUpdated documentation:
DIRECTORY.md- Removed entries for deleted files and cleaned up empty folder referencesCloses #7253
clang-format -i --style=file path/to/your/file.java